netdev - Re: [PATCH net-next v2 10/13] net: socionext: use new helper tcp_v6_gso_csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200219123631.GA651277@apalos.home>
Date:   Wed, 19 Feb 2020 14:36:31 +0200
From:   Ilias Apalodimas <ilias.apalodimas@...aro.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 10/13] net: socionext: use new helper
 tcp_v6_gso_csum_prep

On Tue, Feb 18, 2020 at 09:09:17PM +0100, Heiner Kallweit wrote:
> Use new helper tcp_v6_gso_csum_prep in additional network drivers.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
>  drivers/net/ethernet/socionext/netsec.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index e8224b543..6266926fe 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1148,11 +1148,7 @@ static netdev_tx_t netsec_netdev_start_xmit(struct sk_buff *skb,
>  				~tcp_v4_check(0, ip_hdr(skb)->saddr,
>  					      ip_hdr(skb)->daddr, 0);
>  		} else {
> -			ipv6_hdr(skb)->payload_len = 0;
> -			tcp_hdr(skb)->check =
> -				~csum_ipv6_magic(&ipv6_hdr(skb)->saddr,
> -						 &ipv6_hdr(skb)->daddr,
> -						 0, IPPROTO_TCP, 0);
> +			tcp_v6_gso_csum_prep(skb);
>  		}
>  
>  		tx_ctrl.tcp_seg_offload_flag = true;
> -- 
> 2.25.1
> 
> 

Acked-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>