netdev - Re: [RFC] slip: not call free_netdev before rtnl_unlock in slip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6bbb6ef-2ae5-6450-fb01-1fc9265f0483@huawei.com>
Date:   Wed, 19 Feb 2020 22:39:40 +0800
From:   yangerkun <yangerkun@...wei.com>
To:     "davem@...emloft.net" <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        maowenan <maowenan@...wei.com>, <yangerkun@...wei.com>
Subject: Re: [RFC] slip: not call free_netdev before rtnl_unlock in slip_open

Ping again..

On 2020/2/16 13:32, yangerkun wrote:
> Ping.
> 
> On 2020/2/13 17:32, yangerkun wrote:
>> As the description before netdev_run_todo, we cannot call free_netdev
>> before rtnl_unlock, fix it by reorder the code.
>>
>> Signed-off-by: yangerkun <yangerkun@...wei.com>
>> ---
>>   drivers/net/slip/slip.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c
>> index 6f4d7ba8b109..babb01888b78 100644
>> --- a/drivers/net/slip/slip.c
>> +++ b/drivers/net/slip/slip.c
>> @@ -863,7 +863,10 @@ static int slip_open(struct tty_struct *tty)
>>       tty->disc_data = NULL;
>>       clear_bit(SLF_INUSE, &sl->flags);
>>       sl_free_netdev(sl->dev);
>> +    /* do not call free_netdev before rtnl_unlock */
>> +    rtnl_unlock();
>>       free_netdev(sl->dev);
>> +    return err;
>>   err_exit:
>>       rtnl_unlock();
>>