lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 19 Feb 2020 16:26:14 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     shawnguo@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, davem@...emloft.net,
        netdev@...r.kernel.org, vivien.didelot@...il.com,
        f.fainelli@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 net-next/devicetree 2/5] net: dsa: felix: Use
 PHY_INTERFACE_MODE_INTERNAL instead of GMII

On Wed, Feb 19, 2020 at 05:12:56PM +0200, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@....com>
> 
> phy-mode = "gmii" is confusing because it may mean that the port
> supports the 8-bit-wide parallel data interface pinout, which it
> doesn't.
> 
> It may also be confusing because one of the "gmii" internal ports is
> actually overclocked to run at 2.5Gbps (even though, yes, as far as the
> switch MAC is concerned, it still thinks it's gigabit).
> 
> So use the phy-mode = "internal" property to describe the internal ports
> inside the NXP LS1028A chip (the ones facing the ENETC). The change
> should be fine, because the device tree bindings document is yet to be
> introduced, and there are no stable DT blobs in use.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew

Powered by blists - more mailing lists