netdev - Re: [PATCH bpf-next 0/3] sockmap/ktls: Simplify how we restore sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d998c5a-18cb-bbe7-cc85-460efb32e9de@iogearbox.net>
Date:   Wed, 19 Feb 2020 18:36:11 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        John Fastabend <john.fastabend@...il.com>
Subject: Re: [PATCH bpf-next 0/3] sockmap/ktls: Simplify how we restore
 sk_prot callbacks

On 2/17/20 1:15 PM, Jakub Sitnicki wrote:
> This series has been split out from "Extend SOCKMAP to store listening
> sockets" [0]. I think it stands on its own, and makes the latter series
> smaller, which will make the review easier, hopefully.
> 
> The essence is that we don't need to do a complicated dance in
> sk_psock_restore_proto, if we agree that the contract with tcp_update_ulp
> is to restore callbacks even when the socket doesn't use ULP. This is what
> tcp_update_ulp currently does, and we just make use of it.
> 
> Series is accompanied by a test for a particularly tricky case of restoring
> callbacks when we have both sockmap and tls callbacks configured in
> sk->sk_prot.
> 
> [0] https://lore.kernel.org/bpf/20200127131057.150941-1-jakub@cloudflare.com/
> 
> 
> Jakub Sitnicki (3):
>    bpf, sk_msg: Let ULP restore sk_proto and write_space callback
>    bpf, sk_msg: Don't clear saved sock proto on restore
>    selftests/bpf: Test unhashing kTLS socket after removing from map
> 
>   include/linux/skmsg.h                         |  17 +--
>   .../selftests/bpf/prog_tests/sockmap_ktls.c   | 123 ++++++++++++++++++
>   2 files changed, 124 insertions(+), 16 deletions(-)
>   create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> 

Applied, thanks!