| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Feb 2020 18:49:58 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Richard Henderson <rth@...ddle.net>,
Ivan Kokshaysky <ink@...assic.park.msu.ru>,
Matt Turner <mattst88@...il.com>,
Alexey Brodkin <abrodkin@...opsys.com>,
Vineet Gupta <vgupta@...opsys.com>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
Helge Deller <deller@....de>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Michael Ellerman <mpe@...erman.id.au>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
Rich Felker <dalias@...c.org>,
Dave Airlie <airlied@...hat.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>,
Ben Skeggs <bskeggs@...hat.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Jiri Slaby <jirislaby@...il.com>,
Nick Kossifidis <mickflemm@...il.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Kalle Valo <kvalo@...eaurora.org>,
"David S. Miller" <davem@...emloft.net>,
Dave Jiang <dave.jiang@...el.com>,
Jon Mason <jdmason@...zu.us>, Allen Hubbe <allenbh@...il.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Arnd Bergmann <arnd@...db.de>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Andrew Morton <akpm@...ux-foundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-snps-arc@...ts.infradead.org, linux-parisc@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org,
dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
linux-media@...r.kernel.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, linux-ntb@...glegroups.com,
virtualization@...ts.linux-foundation.org,
linux-arch@...r.kernel.org
Cc: Krzysztof Kozlowski <krzk@...nel.org>
Subject: [RESEND PATCH v2 0/9] iomap: Constify ioreadX() iomem argument
Hi,
Changes since v1
================
https://lore.kernel.org/lkml/1578415992-24054-1-git-send-email-krzk@kernel.org/
1. Constify also ioreadX_rep() and mmio_insX(),
2. Squash lib+alpha+powerpc+parisc+sh into one patch for bisectability,
3. Add acks and reviews,
4. Re-order patches so all optional driver changes are at the end.
Description
===========
The ioread8/16/32() and others have inconsistent interface among the
architectures: some taking address as const, some not.
It seems there is nothing really stopping all of them to take
pointer to const.
Patchset was only compile tested on affected architectures. No real
testing.
volatile
========
There is still interface inconsistency between architectures around
"volatile" qualifier:
- include/asm-generic/io.h:static inline u32 ioread32(const volatile void __iomem *addr)
- include/asm-generic/iomap.h:extern unsigned int ioread32(const void __iomem *);
This is still discussed and out of scope of this patchset.
Merging
=======
Multiple architectures are affected in first patch so acks are welcomed.
1. All patches depend on first patch,
2. Patches 2-4 unify the interface also in few drivers,
3. PAtches 5-9 are optional cleanup, without actual impact.
Best regards,
Krzysztof
Krzysztof Kozlowski (9):
iomap: Constify ioreadX() iomem argument (as in generic
implementation)
rtl818x: Constify ioreadX() iomem argument (as in generic
implementation)
ntb: intel: Constify ioreadX() iomem argument (as in generic
implementation)
virtio: pci: Constify ioreadX() iomem argument (as in generic
implementation)
arc: Constify ioreadX() iomem argument (as in generic implementation)
drm/mgag200: Constify ioreadX() iomem argument (as in generic
implementation)
drm/nouveau: Constify ioreadX() iomem argument (as in generic
implementation)
media: fsl-viu: Constify ioreadX() iomem argument (as in generic
implementation)
ath5k: Constify ioreadX() iomem argument (as in generic
implementation)
arch/alpha/include/asm/core_apecs.h | 6 +-
arch/alpha/include/asm/core_cia.h | 6 +-
arch/alpha/include/asm/core_lca.h | 6 +-
arch/alpha/include/asm/core_marvel.h | 4 +-
arch/alpha/include/asm/core_mcpcia.h | 6 +-
arch/alpha/include/asm/core_t2.h | 2 +-
arch/alpha/include/asm/io.h | 12 ++--
arch/alpha/include/asm/io_trivial.h | 16 ++---
arch/alpha/include/asm/jensen.h | 2 +-
arch/alpha/include/asm/machvec.h | 6 +-
arch/alpha/kernel/core_marvel.c | 2 +-
arch/alpha/kernel/io.c | 12 ++--
arch/arc/plat-axs10x/axs10x.c | 4 +-
arch/parisc/include/asm/io.h | 4 +-
arch/parisc/lib/iomap.c | 72 +++++++++----------
arch/powerpc/kernel/iomap.c | 28 ++++----
arch/sh/kernel/iomap.c | 22 +++---
drivers/gpu/drm/mgag200/mgag200_drv.h | 4 +-
drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-
drivers/media/platform/fsl-viu.c | 2 +-
drivers/net/wireless/ath/ath5k/ahb.c | 10 +--
.../realtek/rtl818x/rtl8180/rtl8180.h | 6 +-
drivers/ntb/hw/intel/ntb_hw_gen1.c | 2 +-
drivers/ntb/hw/intel/ntb_hw_gen3.h | 2 +-
drivers/ntb/hw/intel/ntb_hw_intel.h | 2 +-
drivers/virtio/virtio_pci_modern.c | 6 +-
include/asm-generic/iomap.h | 28 ++++----
include/linux/io-64-nonatomic-hi-lo.h | 4 +-
include/linux/io-64-nonatomic-lo-hi.h | 4 +-
lib/iomap.c | 30 ++++----
30 files changed, 156 insertions(+), 156 deletions(-)
--
2.17.1
Powered by blists - more mailing lists