netdev - RE: [PATCH bpf-next] selftests/bpf: Fix build of sockmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Feb 2020 13:26:46 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     daniel@...earbox.net, netdev@...r.kernel.org, bpf@...r.kernel.org,
        kernel-team@...com
Subject: RE: [PATCH bpf-next] selftests/bpf: Fix build of sockmap_ktls.c

Alexei Starovoitov wrote:
> The selftests fails to build with:
> tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c: In function ‘test_sockmap_ktls_disconnect_after_delete’:
> tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c:72:37: error: ‘TCP_ULP’ undeclared (first use in this function)
>    72 |  err = setsockopt(cli, IPPROTO_TCP, TCP_ULP, "tls", strlen("tls"));
>       |                                     ^~~~~~~
> 
> Similar to commit that fixes build of sockmap_basic.c on systems with old
> /usr/include fix the build of sockmap_ktls.c
> 
> Fixes: d1ba1204f2ee ("selftests/bpf: Test unhashing kTLS socket after removing from map")
> Signed-off-by: Alexei Starovoitov <ast@...nel.org>
> ---
>  tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> index 589b50c91b96..06b86addc181 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_ktls.c
> @@ -7,6 +7,7 @@
>  #include "test_progs.h"
>  
>  #define MAX_TEST_NAME 80
> +#define TCP_ULP 31
>  
>  static int tcp_server(int family)
>  {
> -- 
> 2.23.0
> 

Thanks.

Acked-by: John Fastabend <john.fastabend@...il.com>