netdev - Re: About r8169 regression 5.4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Feb 2020 22:54:14 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Vincas Dargis <vindrg@...il.com>,
        Salvatore Bonaccorso <carnil@...ian.org>
Cc:     netdev@...r.kernel.org
Subject: Re: About r8169 regression 5.4

On 17.02.2020 20:59, Heiner Kallweit wrote:
> On 17.02.2020 19:08, Vincas Dargis wrote:
>> 2020-02-16 01:27, Heiner Kallweit rašė:
>>> One more idea:
>>> Commit "r8169: enable HW csum and TSO" enables certain hardware offloading by default.
>>> Maybe your chip version has a hw issue with offloading. You could try:
>>>
>>> 1. Disable TSO
>>> ethtool -K <if> tso off
>>>
>>> 2. If this didn't help, disable all offloading.
>>> ethtool -K <if> tx off sg off tso off
>>>
>>
>> Unmodified 5.4 was running successfully for whole Sunday with `tx off sg off tso off`! Disabling only tso did not help, while disabling all actually avoided the timeout.
>>
> Great, thanks a lot for testing! Then the bisecting shouldn't be needed. Since 5.4 these features are enabled by default,
> up to 5.3 they are available but have to be enabled explicitly. This should explain the observed behavior.
> So it looks like this chip version has a hw issue with tx checksumming. I contacted Realtek to see whether
> they are aware of any such hw issue. Depending on their feedback we may have to add a quirk for this chip version
> to not enable these features by default.
> 
Realtek responded that they are not aware of a HW issue with RTL8411b. They will try to reproduce the error,
in addition they ask to test whether same issue occurs with their own driver, r8168.
Would be great if you could give r8168 a try. Most distributions provide it as an optional package.
Worst case it can be downloaded from Realtek's website, then it needs to be compiled.