netdev - Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: fix vlan setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218195235.GB80929@t480s.localdomain>
Date:   Tue, 18 Feb 2020 19:52:35 -0500
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Ido Schimmel <idosch@...sch.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: fix vlan setup

Hi Russell,

On Tue, 18 Feb 2020 23:48:06 +0000, Russell King - ARM Linux admin <linux@...linux.org.uk> wrote:
> On Tue, Feb 18, 2020 at 11:34:38AM -0800, Florian Fainelli wrote:
> > Russell, in your tests/examples, did the tagged traffic of $VN continue
> > to work after you toggled vlan_filtering on? If so, that must be because
> > on a bridge with VLAN filtering disabled, we still ended up calling down
> > to the lan1..6 ndo_vlan_rx_add_vid() and so we do have VLAN entries
> > programmed for $VN.
> 
> From what I remember, _all_ traffic was blocked because the VTU
> was completely empty when vlan filtering is turned on.

Not sure if the default PVID is 0 or 1, but one of them is ignored
somehow. Setting up a default PVID in the first place is a way to ensure
the programmation of the VTU, like in the following example:

    # ip link add name br0 type bridge vlan_filtering 1 vlan_default_pvid 42
    # ip link set master br0 dev lan2 up
    # cat /sys/kernel/debug/mv88e6xxx/sw0/vtu 
    vid 42	fid 1	sid 0	dpv 0 unmodified 2 untagged 10 unmodified

Russell can you test this? If things work out for you when setting up a VLAN
filtering aware bridge with your own default PVID before enslaving DSA ports,
then the problem is narrowed to propagating the default bridge configuration
(default PVID and configuration after enabling VLAN filtering).


Thanks,

	Vivien