netdev - Re: [PATCH net-next v5] net: page_pool: API cleanup and comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200220.100938.2134816727649118049.davem@davemloft.net>
Date:   Thu, 20 Feb 2020 10:09:38 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ilias.apalodimas@...aro.org
Cc:     netdev@...r.kernel.org, jonathan.lemon@...il.com,
        lorenzo@...nel.org, toke@...hat.com, brouer@...hat.com,
        thomas.petazzoni@...tlin.com, jaswinder.singh@...aro.org,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com, hawk@...nel.org,
        kuba@...nel.org, ast@...nel.org, daniel@...earbox.net,
        john.fastabend@...il.com, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, bpf@...r.kernel.org
Subject: Re: [PATCH net-next v5] net: page_pool: API cleanup and comments

From: Ilias Apalodimas <ilias.apalodimas@...aro.org>
Date: Thu, 20 Feb 2020 09:41:55 +0200

> Functions starting with __ usually indicate those which are exported,
> but should not be called directly. Update some of those declared in the
> API and make it more readable.
> 
> page_pool_unmap_page() and page_pool_release_page() were doing
> exactly the same thing calling __page_pool_clean_page().  Let's
> rename __page_pool_clean_page() to page_pool_release_page() and
> export it in order to show up on perf logs and get rid of
> page_pool_unmap_page().
> 
> Finally rename __page_pool_put_page() to page_pool_put_page() since we
> can now directly call it from drivers and rename the existing
> page_pool_put_page() to page_pool_put_full_page() since they do the same
> thing but the latter is trying to sync the full DMA area.
> 
> This patch also updates netsec, mvneta and stmmac drivers which use
> those functions.
> 
> Suggested-by: Jonathan Lemon <jonathan.lemon@...il.com>
> Acked-by: Toke Høiland-Jørgensen <toke@...hat.com>
> Acked-by: Jesper Dangaard Brouer <brouer@...hat.com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@...aro.org>

Applied, thanks Ilias.