netdev - Re: [PATCH bpf-next] libbpf: relax check whether BTF is mandatory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJdONoTQmu8WugEXLsiZOzbb9Kiw-Q9ZVC+pDiSUufTOQ@mail.gmail.com>
Date:   Thu, 20 Feb 2020 11:05:07 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Julia Kartseva <hex@...com>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next] libbpf: relax check whether BTF is mandatory

On Wed, Feb 19, 2020 at 10:27 PM Andrii Nakryiko <andriin@...com> wrote:
>
> If BPF program is using BTF-defined maps, BTF is required only for
> libbpf itself to process map definitions. If after that BTF fails to
> be loaded into kernel (e.g., if it doesn't support BTF at all), this
> shouldn't prevent valid BPF program from loading. Existing
> retry-without-BTF logic for creating maps will succeed to create such
> maps without any problems. So, presence of .maps section shouldn't make
> BTF required for kernel. Update the check accordingly.
>
> Validated by ensuring simple BPF program with BTF-defined maps is still
> loaded on old kernel without BTF support and map is correctly parsed and
> created.
>
> Fixes: abd29c931459 ("libbpf: allow specifying map definitions using BTF")
> Reported-by: Julia Kartseva <hex@...com>
> Signed-off-by: Andrii Nakryiko <andriin@...com>

Applied. Thanks