netdev - Re: [PATCH net-next 0/3] Improve bind(addr, 0) behaviour.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iK2LHmjHsQw4yYFy-WoKT6YnpRPOKJkEXzJuTEaG+ayNw@mail.gmail.com>
Date:   Thu, 20 Feb 2020 11:58:00 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Kuniyuki Iwashima <kuniyu@...zon.co.jp>
Cc:     David Miller <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        kuni1840@...il.com, netdev <netdev@...r.kernel.org>,
        osa-contribution-log@...zon.com
Subject: Re: [PATCH net-next 0/3] Improve bind(addr, 0) behaviour.

On Thu, Feb 20, 2020 at 7:20 AM Kuniyuki Iwashima <kuniyu@...zon.co.jp> wrote:
>
> Currently we fail to bind sockets to ephemeral ports when all of the ports
> are exhausted even if all sockets have SO_REUSEADDR enabled. In this case,
> we still have a chance to connect to the different remote hosts.
>
> The second and third patches fix the behaviour to fully utilize all space
> of the local (addr, port) tuples.
>
> Kuniyuki Iwashima (3):
>   tcp: Remove unnecessary conditions in inet_csk_bind_conflict().
>   tcp: bind(addr, 0) remove the SO_REUSEADDR restriction when ephemeral
>     ports are exhausted.
>   tcp: Prevent port hijacking when ports are exhausted
>
>  net/ipv4/inet_connection_sock.c | 36 ++++++++++++++++++++++-----------
>  1 file changed, 24 insertions(+), 12 deletions(-)

I am travelling at the moment, so I can not really look at these
patches with enough time.

I would appreciate it if you provide tests to demonstrate your patches are safe.

Thanks.