netdev - Re: [PATCH net-next 00/16] Clean driver, module and FW versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200220171714.60a70238@kicinski-fedora-PC1C0HJN>
Date:   Thu, 20 Feb 2020 17:17:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Leon Romanovsky <leonro@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 00/16] Clean driver, module and FW versions

On Thu, 20 Feb 2020 16:58:39 +0200 Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@...lanox.com>
> 
> Hi,
> 
> This is first patchset to netdev (already sent RDMA [1] and arch/um)
> in attempt to unify the version management for in-tree kernel code.
> The patches follow already accepted ethtool change [2] to set as
> a default linux kernel version.
> 
> It allows us to remove driver version and present to the users unified
> picture of driver version, which is similar to default MODULE_VERSION().

Thanks for doing this! The patches look good to me.

A few minor nit picks I registered, IDK how hard we want to press 
on these:

 - it seems in couple places you remove the last user of DRV_RELDATE,
   but not the define. In case of bonding maybe we can remove the date
   too. IDK what value it brings in the description, other than perhaps
   humoring people;
 - we should probably give people a heads up by CCing maintainers
   (regardless of how dumb we find not bothering to read the ML as
   a maintainer);
 - one on the FW below..

> As part of this series, I deleted various creative attempts to mark
> absence of FW. There is no need to set "N/A" in ethtool ->fw_version
> field and it is enough to do not set it.

These seem reasonable to me, although in abundance of caution it could
be a good idea to have them as separate commits so we can revert more
easily. Worse come to worst.

> 1.
> The code is compile tested and passes 0-day kbuild.
> 2.
> The proposed changes are based on commit:
>   2bb07f4e1d86 ("tc-testing: updated tdc tests for basic filter")
> 3.
> WIP branch is [3].
> 
> [1] https://lore.kernel.org/linux-rdma/20200220071239.231800-1-leon@kernel.org/
> [2] https://lore.kernel.org/linux-rdma/20200127072028.19123-1-leon@kernel.org/
> [3] https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=ethtool