netdev - Re: [PATCH net-next v3 2/2] ptp: Add a ptp clock driver for IDT 82P33 SMU.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 09:19:12 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     min.li.xe@...esas.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] ptp: Add a ptp clock driver for IDT
 82P33 SMU.

On Fri, Feb 21, 2020 at 03:51:28AM -0800, Richard Cochran wrote:
> > +	channel->ptp_clock = ptp_clock_register(&channel->caps, NULL);
> > +
> > +	if (IS_ERR(channel->ptp_clock)) {
> > +		err = PTR_ERR(channel->ptp_clock);
> > +		channel->ptp_clock = NULL;
> > +		return err;
> > +	}
> 
> The function, ptp_clock_register(), can also return NULL.  Please
> handle that case as well.
> 
> > +
> > +	if (!channel->ptp_clock)
> > +		return -ENOTSUPP;

Duh!  Never mind that last comment!

Thanks,
Richard