netdev - Re: [RFC 12/18] net: atlantic: MACSec offload skeleton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200221182130.GF3530@kwain>
Date:   Fri, 21 Feb 2020 19:21:30 +0100
From:   Antoine Tenart <antoine.tenart@...tlin.com>
To:     Igor Russkikh <irusskikh@...vell.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Mark Starovoytov <mstarovoitov@...vell.com>,
        Dmitry Bogdanov <dbogdanov@...vell.com>
Subject: Re: [RFC 12/18] net: atlantic: MACSec offload skeleton

Hello,

On Fri, Feb 14, 2020 at 06:02:52PM +0300, Igor Russkikh wrote:
> From: Dmitry Bogdanov <dbogdanov@...vell.com>
> --- a/drivers/net/ethernet/aquantia/atlantic/Makefile
> +++ b/drivers/net/ethernet/aquantia/atlantic/Makefile
> @@ -8,6 +8,8 @@
>  
>  obj-$(CONFIG_AQTION) += atlantic.o
>  
> +ccflags-y += -I$(src)
> +
>  atlantic-objs := aq_main.o \
>  	aq_nic.o \
>  	aq_pci_func.o \
> @@ -18,6 +20,7 @@ atlantic-objs := aq_main.o \
>  	aq_drvinfo.o \
>  	aq_filters.o \
>  	aq_phy.o \
> +	aq_macsec.o \

You can exclude this file from the build when MACsec isn't enabled and
remove the #if in the corresponding C file. If MACsec is set to be built
as a module, your driver cannot work as the pn wrap callback won't be
callable.

You would also need to define a dependency on 'MACSEC || MACSEC=n' for
the pn wrap callback to work.

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com