netdev - Re: [PATCH net-next] net/mlx5: Fix header guard in rsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <89dda0680320d0ce1b42093e59985313e2a1ac50.camel@mellanox.com>
Date:   Fri, 21 Feb 2020 18:37:50 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "natechancellor@...il.com" <natechancellor@...il.com>,
        "leon@...nel.org" <leon@...nel.org>
CC:     Jiri Pirko <jiri@...lanox.com>, Aya Levin <ayal@...lanox.com>,
        "clang-built-linux@...glegroups.com" 
        <clang-built-linux@...glegroups.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Moshe Shemesh <moshe@...lanox.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: Fix header guard in rsc_dump.h

On Thu, 2020-02-20 at 22:24 -0700, Nathan Chancellor wrote:
> Clang warns:
> 
>  In file included from
>  ../drivers/net/ethernet/mellanox/mlx5/core/main.c:73:
>  ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:4:9:
> warning:
>  '__MLX5_RSC_DUMP_H' is used as a header guard here, followed by
> #define
>  of a different macro [-Wheader-guard]
>  #ifndef __MLX5_RSC_DUMP_H
>          ^~~~~~~~~~~~~~~~~
>  ../drivers/net/ethernet/mellanox/mlx5/core/diag/rsc_dump.h:5:9:
> note:
>  '__MLX5_RSC_DUMP__H' is defined here; did you mean
> '__MLX5_RSC_DUMP_H'?
>  #define __MLX5_RSC_DUMP__H
>          ^~~~~~~~~~~~~~~~~~
>          __MLX5_RSC_DUMP_H
>  1 warning generated.
> 
> Make them match to get the intended behavior and remove the warning.

Applied to net-next-mlx5

Thanks !