netdev - Re: [PATCH net-next 0/2] net: phy: unregister MDIO bus in _devm_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200221.114252.1572219458583551651.davem@davemloft.net>
Date:   Fri, 21 Feb 2020 11:42:52 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk,
        nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] net: phy: unregister MDIO bus in
 _devm_mdiobus_free if needed

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Mon, 17 Feb 2020 21:34:10 +0100

> If using managed MDIO bus handling (devm_mdiobus_alloc et al) we still
> have to manually unregister the MDIO bus. For drivers that don't depend
> on unregistering the MDIO bus at a specific, earlier point in time we
> can make driver author's life easier by automagically unregistering
> the MDIO bus. This extension is transparent to existing drivers.
> 
> Heiner Kallweit (2):
>   net: phy: unregister MDIO bus in _devm_mdiobus_free if needed
>   r8169: let managed MDIO bus handling unregister the MDIO bus

Heiner, I'm going to defer on this.

The existing behavior, this proposal, and the alternatives you
described with Andrew Lunn in the patch #1 discussion all seem
equally cumbersome and awkward to me.