netdev - Re: [PATCH net-next V2 0/7] mlxfw: Improve error reporting and FW reactivate support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200221145157.20c8eb7c@kicinski-fedora-PC1C0HJN>
Date:   Fri, 21 Feb 2020 14:51:57 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next V2 0/7] mlxfw: Improve error reporting and FW
 reactivate support

On Fri, 21 Feb 2020 21:45:56 +0000 Saeed Mahameed wrote:
> This patchset improves mlxfw error reporting to netlink and to
> kernel log.
> 
> V2:
>  - Use proper err codes, EBUSY/EIO instead of EALREADY/EREMOTEIO
>  - Fix typo.

LGTM, thanks. FWIW:

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

> From Eran and me.
> 
> 1) patch #1, Make mlxfw/mlxsw fw flash devlink status notify generic,
>    and enable it for mlx5.
> 
> 2) patches #2..#5 are improving mlxfw flash error messages by
> reporting detailed mlxfw FSM error messages to netlink and kernel log.
> 
> 3) patches #6,7 From Eran: Add FW reactivate flow to  mlxfw and mlx5