netdev - RE: [PATCH bpf-next v7 11/11] selftests/bpf: Tests for sockmap/sockhash holding listening sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e4f54eaee9c1_18d22b0a1febc5b8cc@john-XPS-13-9370.notmuch>
Date:   Thu, 20 Feb 2020 19:56:26 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        John Fastabend <john.fastabend@...il.com>,
        Lorenz Bauer <lmb@...udflare.com>, Martin Lau <kafai@...com>
Subject: RE: [PATCH bpf-next v7 11/11] selftests/bpf: Tests for
 sockmap/sockhash holding listening sockets

Jakub Sitnicki wrote:
> Now that SOCKMAP and SOCKHASH map types can store listening sockets,
> user-space and BPF API is open to a new set of potential pitfalls.
> 
> Exercise the map operations, with extra attention to code paths susceptible
> to races between map ops and socket cloning, and BPF helpers that work with
> SOCKMAP/SOCKHASH to gain confidence that all works as expected.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---
>  .../selftests/bpf/prog_tests/sockmap_listen.c | 1496 +++++++++++++++++
>  .../selftests/bpf/progs/test_sockmap_listen.c |   98 ++
>  2 files changed, 1594 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/sockmap_listen.c
>  create mode 100644 tools/testing/selftests/bpf/progs/test_sockmap_listen.c

Reminds me I need to clean up the sock{map|hash} tests as well.

Acked-by: John Fastabend <john.fastabend@...il.com>