netdev - Re: [PATCH net] net: genetlink: return the error code when attribute parsing fails.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 22 Feb 2020 07:54:42 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jiri Pirko <jiri@...lanox.com>
Subject: Re: [PATCH net] net: genetlink: return the error code when attribute
 parsing fails.

Fri, Feb 21, 2020 at 07:42:13PM CET, pabeni@...hat.com wrote:
>Currently if attribute parsing fails and the genl family
>does not support parallel operation, the error code returned
>by __nlmsg_parse() is discarded by genl_family_rcv_msg_attrs_parse().
>
>Be sure to report the error for all genl families.
>
>Fixes: c10e6cf85e7d ("net: genetlink: push attrbuf allocation and parsing to a separate function")
>Fixes: ab5b526da048 ("net: genetlink: always allocate separate attrs for dumpit ops")
>Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Thanks!