netdev - Re: [net PATCH] net: Fix Tx hash bound checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0740c47-8b2e-8554-c78d-90461dde1177@cogentembedded.com>
Date:   Sat, 22 Feb 2020 11:07:24 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Amritha Nambiar <amritha.nambiar@...el.com>,
        netdev@...r.kernel.org, davem@...emloft.net
Cc:     alexander.h.duyck@...el.com, sridhar.samudrala@...el.com
Subject: Re: [net PATCH] net: Fix Tx hash bound checking

Hello!

On 22.02.2020 5:09, Amritha Nambiar wrote:

> Fixes: commit 1b837d489e06 ("net: Revoke export for __skb_tx_hash, update it to just be static skb_tx_hash")
> Fixes: commit eadec877ce9c ("net: Add support for subordinate traffic classes to netdev_pick_tx")

    No need to say "commit" here. And All tags should be together (below the 
patch description).

> Fixes the lower and upper bounds when there are multiple TCs and
> traffic is on the the same TC on the same device.
> 
> The lower bound is represented by 'qoffset' and the upper limit for
> hash value is 'qcount + qoffset'. This gives a clean Rx to Tx queue
> mapping when there are multiple TCs, as the queue indices for upper TCs
> will be offset by 'qoffset'.
> 
> Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
[...]

MBR, Sergei