netdev - Re: [PATCH] vhost: Check docket sk_family instead of call getname

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200222.214329.2179749831482216415.davem@davemloft.net>
Date:   Sat, 22 Feb 2020 21:43:29 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     eperezma@...hat.com
Cc:     mst@...hat.com, jasowang@...hat.com, kvm@...r.kernel.org,
        netdev@...r.kernel.org, stable@...r.kernel.org, jreuter@...na.de,
        ralf@...ux-mips.org
Subject: Re: [PATCH] vhost: Check docket sk_family instead of call getname

From: Eugenio Pérez <eperezma@...hat.com>
Date: Fri, 21 Feb 2020 12:06:56 +0100

> Doing so, we save one call to get data we already have in the struct.
> 
> Also, since there is no guarantee that getname use sockaddr_ll
> parameter beyond its size, we add a little bit of security here.
> It should do not do beyond MAX_ADDR_LEN, but syzbot found that
> ax25_getname writes more (72 bytes, the size of full_sockaddr_ax25,
> versus 20 + 32 bytes of sockaddr_ll + MAX_ADDR_LEN in syzbot repro).
> 
> Fixes: 3a4d5c94e9593 ("vhost_net: a kernel-level virtio server")
> Reported-by: syzbot+f2a62d07a5198c819c7b@...kaller.appspotmail.com
> Signed-off-by: Eugenio Pérez <eperezma@...hat.com>

Applied and queued up for -stable, thanks.