netdev - Re: [PATCH] net: core: devlink.c: Hold devlink->lock from the beginning of devlink_dpipe_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200223181746.GF2228@nanopsycho>
Date:   Sun, 23 Feb 2020 19:17:46 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     madhuparnabhowmik10@...il.com
Cc:     jiri@...lanox.com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, joel@...lfernandes.org,
        linux-kernel-mentees@...ts.linuxfoundation.org, paulmck@...nel.org
Subject: Re: [PATCH] net: core: devlink.c: Hold devlink->lock from the
 beginning of devlink_dpipe_table_register()

Sun, Feb 23, 2020 at 12:22:33PM CET, madhuparnabhowmik10@...il.com wrote:
>From: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>
>
>devlink_dpipe_table_find() should be called under either
>rcu_read_lock() or devlink->lock. devlink_dpipe_table_register()
>calls devlink_dpipe_table_find() without holding the lock
>and acquires it later. Therefore hold the devlink->lock
>from the beginning of devlink_dpipe_table_register().
>
>Suggested-by: Jiri Pirko <jiri@...lanox.com>
>Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@...il.com>

Reviewed-by: Jiri Pirko <jiri@...lanox.com>