netdev - Re: [PATCH net-next 5/9] net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200223.210620.497537969860161356.davem@davemloft.net>
Date:   Sun, 23 Feb 2020 21:06:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     grygorii.strashko@...com
Cc:     rogerq@...com, t-kristo@...com, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, robh+dt@...nel.org,
        peter.ujfalusi@...com, nsekhar@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 5/9] net: ethernet: ti: introduce am65x/j721e
 gigabit eth subsystem driver

From: Grygorii Strashko <grygorii.strashko@...com>
Date: Sat, 22 Feb 2020 17:57:48 +0200

> +/**
> + * struct am65_cpsw_regdump_hdr - regdump record header
> + *
> + * @module_id: CPSW module ID
> + * @len: CPSW module registers space length in u32
> + */
> +
> +struct am65_cpsw_regdump_hdr {
> +	u32 module_id;
> +	u32 len;
> +} __packed;

I see no reason for this __packed attribute, please remove it.

> +void am65_cpsw_nuss_adjust_link(struct net_device *ndev)
> +{
> +	struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
> +	struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> +	struct phy_device *phy = port->slave.phy;
> +	u32 mac_control = 0;

Please order the local variables in reverse christmas tree order,
thank you.

> +static void am65_cpsw_nuss_ndo_slave_set_rx_mode(struct net_device *ndev)
> +{
> +	struct am65_cpsw_port *port = am65_ndev_to_port(ndev);
> +	struct am65_cpsw_common *common = am65_ndev_to_common(ndev);
> +	u32 port_mask;
> +	bool promisc;

Likewise.

> +static int am65_cpsw_nuss_rx_push(struct am65_cpsw_common *common,
> +				  struct sk_buff *skb)
> +{
> +	struct cppi5_host_desc_t *desc_rx;
> +	struct am65_cpsw_rx_chn *rx_chn = &common->rx_chns;
> +	struct device *dev = common->dev;
> +	dma_addr_t desc_dma;
> +	dma_addr_t buf_dma;
> +	u32 pkt_len = skb_tailroom(skb);
> +	void *swdata;

Likewsie.

And so on, and so forth, for your entire submission.

Thank you.