netdev - Re: [PATCH net v2] net: bridge: fix stale eth hdr pointer in br_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D49B5587-5365-4B09-9728-0BE23056A974@cumulusnetworks.com>
Date:   Mon, 24 Feb 2020 19:06:39 +0200
From:   nikolay@...ulusnetworks.com
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     netdev@...r.kernel.org, davem@...emloft.net,
        roopa@...ulusnetworks.com, bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net v2] net: bridge: fix stale eth hdr pointer in br_dev_xmit

On 24 February 2020 18:54:27 EET, Stephen Hemminger <stephen@...workplumber.org> wrote:
>On Mon, 24 Feb 2020 18:46:22 +0200
>Nikolay Aleksandrov <nikolay@...ulusnetworks.com> wrote:
>
>> -	eth = eth_hdr(skb);
>>  	skb_pull(skb, ETH_HLEN)
>
>you could just swap these two lines.

Can't, still caching the wrong mac_header offset. br_allowed_ingress() can change the head pointer and also the offsets inside.