[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200224180754.jg7xijof3n32ywjn@kafai-mbp>
Date: Mon, 24 Feb 2020 10:07:54 -0800
From: Martin KaFai Lau <kafai@...com>
To: Jakub Sitnicki <jakub@...udflare.com>
CC: <bpf@...r.kernel.org>, <netdev@...r.kernel.org>,
<kernel-team@...udflare.com>, Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf-next 1/2] selftests/bpf: Run reuseport tests only
with supported socket types
On Mon, Feb 24, 2020 at 02:53:26PM +0100, Jakub Sitnicki wrote:
> SOCKMAP and SOCKHASH map types can be used with reuseport BPF programs but
> don't support yet storing UDP sockets. Instead of marking UDP tests with
> SOCK{MAP,HASH} as skipped, don't run them at all.
>
> Skipped test might signal that the test environment is not suitable for
> running the test, while in reality the functionality is not implemented in
> the kernel yet.
>
> Before:
>
> sh# ./test_progs -t select_reuseport
> …
> #40 select_reuseport:OK
> Summary: 1/126 PASSED, 30 SKIPPED, 0 FAILED
>
> After:
>
> sh# ./test_progs -t select_reuseport
> …
> #40 select_reuseport:OK
> Summary: 1/98 PASSED, 2 SKIPPED, 0 FAILED
Acked-by: Martin KaFai Lau <kafai@...com>
Powered by blists - more mailing lists