[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200224.115528.28812023601108523.davem@davemloft.net>
Date: Mon, 24 Feb 2020 11:55:28 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: jiri@...nulli.us
Cc: netdev@...r.kernel.org, kuba@...nel.org, idosch@...lanox.com,
mlxsw@...lanox.com
Subject: Re: [patch net-next 00/16] mlxsw: Introduce ACL traps
From: Jiri Pirko <jiri@...nulli.us>
Date: Mon, 24 Feb 2020 08:35:42 +0100
> This patchset allows to track packets that are dropped in HW by ACL.
>
> Unlike the existing mlxsw traps, ACL traps are "source traps".
> That means the action is not controlled by HPKT register but directly
> in ACL TRAP action. When devlink user changes action from drop to trap
> and vice versa, it would be needed to go over all instances of ACL TRAP
> action and do change. That does not scale. Instead, resolve this
> by introducing "dummy" group with "thin" policer. The purpose of
> this policer is to drop as many packets as possible. The ones
> that pass through are going to be dropped in devlink code - patch #6
> takes care of that.
>
> First four patches are preparation for introduction of ACL traps in mlxsw
> so it possible to easily change from drop to trap for source traps
> as well - by changing group to "dummy" and back.
Looks good, series applied, thanks Jiri.
Powered by blists - more mailing lists