netdev - Re: [PATCH net-next 05/10] net: mscc: ocelot: don't rely on preprocessor for vcap key/action packing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 15:21:07 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     horatiu.vultur@...rochip.com, alexandre.belloni@...tlin.com,
        andrew@...n.ch, f.fainelli@...il.com, vivien.didelot@...il.com,
        joergen.andreasen@...rochip.com, allan.nielsen@...rochip.com,
        claudiu.manoil@....com, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, alexandru.marginean@....com,
        xiaoliang.yang_1@....com, yangbo.lu@....com, po.liu@....com,
        jiri@...lanox.com, idosch@...sch.org, kuba@...nel.org
Subject: Re: [PATCH net-next 05/10] net: mscc: ocelot: don't rely on
 preprocessor for vcap key/action packing

From: Vladimir Oltean <olteanv@...il.com>
Date: Mon, 24 Feb 2020 15:08:26 +0200

> +static void vcap_key_set(struct vcap_data *data,
> +			 enum vcap_is2_half_key_field field,
> +			 u32 value, u32 mask)
> +{
> +	struct ocelot *ocelot = data->ocelot;
> +	u32 offset = ocelot->vcap_is2_keys[field].offset;
> +	u32 length = ocelot->vcap_is2_keys[field].length;

I know it is a pain in dependency chains of variables like this, but
please use reverse christmas tree ordering.

And likewise for the rest of your submission.

Thank you.