netdev - [PATCH net-next v1 10/18] net/alteon: Properly report FW version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 10:53:03 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     Leon Romanovsky <leonro@...lanox.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Keyur Chudgar <keyur@...amperecomputing.com>,
        Don Fry <pcnet32@...ntier.com>,
        Veaceslav Falico <vfalico@...il.com>,
        Jay Vosburgh <j.vosburgh@...il.com>, linux-acenic@...site.dk,
        Maxime Ripard <mripard@...nel.org>,
        Heiko Stuebner <heiko@...ech.de>,
        Mark Einon <mark.einon@...il.com>,
        Chris Snook <chris.snook@...il.com>,
        linux-rockchip@...ts.infradead.org,
        Iyappan Subramanian <iyappan@...amperecomputing.com>,
        Igor Russkikh <irusskikh@...vell.com>,
        David Dillow <dave@...dillows.org>,
        Netanel Belgazal <netanel@...zon.com>,
        Quan Nguyen <quan@...amperecomputing.com>,
        Jay Cliburn <jcliburn@...il.com>,
        Lino Sanfilippo <LinoSanfilippo@....de>,
        linux-arm-kernel@...ts.infradead.org,
        Andreas Larsson <andreas@...sler.com>,
        Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        linux-kernel@...r.kernel.org, Ion Badulescu <ionut@...ula.org>,
        Arthur Kiyanovski <akiyano@...zon.com>,
        Jes Sorensen <jes@...ined-monkey.org>,
        nios2-dev@...ts.rocketboards.org, Chen-Yu Tsai <wens@...e.org>
Subject: [PATCH net-next v1 10/18] net/alteon: Properly report FW version

From: Leon Romanovsky <leonro@...lanox.com>

The acenic driver assigns FW version in driver version field,
as part of cleanup driver version, set FW version properly.

Signed-off-by: Leon Romanovsky <leonro@...lanox.com>
---
 drivers/net/ethernet/alteon/acenic.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c
index f366faf88eee..5d192d551623 100644
--- a/drivers/net/ethernet/alteon/acenic.c
+++ b/drivers/net/ethernet/alteon/acenic.c
@@ -2699,9 +2699,8 @@ static void ace_get_drvinfo(struct net_device *dev,
 	struct ace_private *ap = netdev_priv(dev);

 	strlcpy(info->driver, "acenic", sizeof(info->driver));
-	snprintf(info->version, sizeof(info->version), "%i.%i.%i",
-		 ap->firmware_major, ap->firmware_minor,
-		 ap->firmware_fix);
+	snprintf(info->fw_version, sizeof(info->version), "%i.%i.%i",
+		 ap->firmware_major, ap->firmware_minor, ap->firmware_fix);

 	if (ap->pdev)
 		strlcpy(info->bus_info, pci_name(ap->pdev),
--
2.24.1