netdev - Re: [PATCH bpf-next 1/2] selftests/bpf: Run reuseport tests only with supported socket types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Feb 2020 16:38:10 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        kernel-team <kernel-team@...udflare.com>,
        Martin Lau <kafai@...com>, Alexei Starovoitov <ast@...nel.org>
Subject: Re: [PATCH bpf-next 1/2] selftests/bpf: Run reuseport tests only with
 supported socket types

On Mon, Feb 24, 2020 at 5:53 AM Jakub Sitnicki <jakub@...udflare.com> wrote:
>
> SOCKMAP and SOCKHASH map types can be used with reuseport BPF programs but
> don't support yet storing UDP sockets. Instead of marking UDP tests with
> SOCK{MAP,HASH} as skipped, don't run them at all.
>
> Skipped test might signal that the test environment is not suitable for
> running the test, while in reality the functionality is not implemented in
> the kernel yet.
>
> Before:
>
>   sh# ./test_progs -t select_reuseport
>   …
>   #40 select_reuseport:OK
>   Summary: 1/126 PASSED, 30 SKIPPED, 0 FAILED
>
> After:
>
>   sh# ./test_progs  -t select_reuseport
>   …
>   #40 select_reuseport:OK
>   Summary: 1/98 PASSED, 2 SKIPPED, 0 FAILED
>
> The remaining two skipped tests are SYN cookies tests, which will be
> addressed in the subsequent patch.
>
> Fixes: 11318ba8cafd ("selftests/bpf: Extend SK_REUSEPORT tests to cover SOCKMAP/SOCKHASH")
> Reported-by: Alexei Starovoitov <ast@...nel.org>
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>

Applied. Thanks