netdev - Re: [PATCH bpf-next 1/7] bpf: sockmap: only check ULP for TCP sockets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPhsuW4WHyBYM0kbS_CQyRTeNvgM-DULA+R7TgkTFLnPec7inQ@mail.gmail.com>
Date:   Tue, 25 Feb 2020 08:45:52 -0800
From:   Song Liu <song@...nel.org>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        John Fastabend <john.fastabend@...il.com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        kernel-team@...udflare.com
Subject: Re: [PATCH bpf-next 1/7] bpf: sockmap: only check ULP for TCP sockets

On Tue, Feb 25, 2020 at 5:57 AM Lorenz Bauer <lmb@...udflare.com> wrote:
>
> The sock map code checks that a socket does not have an active upper
> layer protocol before inserting it into the map. This requires casting
> via inet_csk, which isn't valid for UDP sockets.
>
> Guard checks for ULP by checking inet_sk(sk)->is_icsk first.
>
> Signed-off-by: Lorenz Bauer <lmb@...udflare.com>

Acked-by: Song Liu <songliubraving@...com>