netdev - Re: [bug report] dcbnl: Shorten all command handling functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 25 Feb 2020 10:37:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [bug report] dcbnl: Shorten all command handling functions

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Tue, 25 Feb 2020 10:14:08 +0300

> The patch 7be994138b18: "dcbnl: Shorten all command handling
> functions" from Jun 13, 2012, leads to the following static checker
> warning:
> 
> 	net/dcb/dcbnl.c:1509 dcbnl_ieee_set()
> 	warn: passing signed to unsigned: 'err'

The problem exists before this commit, it's just that the u8 truncated
'err' is passed into dcbnl_reply().

Yeah this is quite a mess.