netdev - Re: [PATCH net] icmp: allow icmpv6_ndo_send to work with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200225.110205.1860690641020290592.davem@davemloft.net>
Date:   Tue, 25 Feb 2020 11:02:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Jason@...c4.com
Cc:     netdev@...r.kernel.org, chenzhou10@...wei.com, hulkci@...wei.com
Subject: Re: [PATCH net] icmp: allow icmpv6_ndo_send to work with
 CONFIG_IPV6=n

From: "Jason A. Donenfeld" <Jason@...c4.com>
Date: Tue, 25 Feb 2020 18:05:35 +0800

> The icmpv6_send function has long had a static inline implementation
> with an empty body for CONFIG_IPV6=n, so that code calling it doesn't
> need to be ifdef'd. The new icmpv6_ndo_send function, which is intended
> for drivers as a drop-in replacement with an identical function
> signature, should follow the same pattern. Without this patch, drivers
> that used to work with CONFIG_IPV6=n now result in a linker error.
> 
> Cc: Chen Zhou <chenzhou10@...wei.com>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Fixes: 0b41713b6066 ("icmp: introduce helper for nat'd source address in network device context")
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Applied, thanks Jason.