netdev - Re: [RFC] wwan: add a new WWAN subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c80d2bbae9606ae09746ad0d382b0b555f9987e3.camel@sipsolutions.net>
Date:   Tue, 25 Feb 2020 20:40:12 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-wireless@...r.kernel.org,
        elder@...aro.org, m.chetan.kumar@...el.com, dcbw@...hat.com,
        bjorn.andersson@...aro.org
Subject: Re: [RFC] wwan: add a new WWAN subsystem

On Tue, 2020-02-25 at 11:00 -0800, David Miller wrote:
> From: Johannes Berg <johannes@...solutions.net>
> Date: Tue, 25 Feb 2020 11:00:53 +0100
> 
> > +static struct wwan_device *wwan_create(struct device *dev)
> > +{
> > +     struct wwan_device *wwan = kzalloc(sizeof(*wwan), GFP_KERNEL);
> > +     u32 id = ++wwan_id_counter;
> > +     int err;
> > +
> > +     lockdep_assert_held(&wwan_mtx);
> > +
> > +     if (WARN_ON(!id))
> > +             return ERR_PTR(-ENOSPC);
> 
> This potentially leaks 'wwan'.

Eagle eyes ... thanks! :)

I suppose this will be totally different if I can integrate with the
component device stuff somehow, will see.

johannes