netdev - Re: [patch net] mlx5: register lag notifier for init network namespace only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e776d9ee6999309d03c84076d3ed22daf6ec9a53.camel@mellanox.com>
Date:   Tue, 25 Feb 2020 22:41:57 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "jiri@...nulli.us" <jiri@...nulli.us>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     Aya Levin <ayal@...lanox.com>, Ran Rozenstein <ranro@...lanox.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        Moshe Shemesh <moshe@...lanox.com>
Subject: Re: [patch net] mlx5: register lag notifier for init network
 namespace only

On Tue, 2020-02-25 at 10:41 -0800, David Miller wrote:
> From: Jiri Pirko <jiri@...nulli.us>
> Date: Tue, 25 Feb 2020 10:25:46 +0100
> 
> > From: Jiri Pirko <jiri@...lanox.com>
> > 
> > The current code causes problems when the unregistering netdevice
> could
> > be different then the registering one.
> > 
> > Since the check in mlx5_lag_netdev_event() does not allow any other
> > network namespace anyway, fix this by registerting the lag notifier
> > per init network namespace only.
> > 
> > Fixes: d48834f9d4b4 ("mlx5: Use dev_net netdevice notifier
> registrations")
> > Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> > Tested-by: Aya Levin <ayal@...lanox.com>
> 
> Saeed, should I apply this directly?

Yes Please. for net i don't have a huge amount of traffic, so it is ok
that patches go directly to net.

Acked-by: Saeed Mahameed <saeedm@...lanox.com>

Thanks,
Saeed.