netdev - Re: [net-next] net/mlx5e: Remove the unnecessary parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5361639fee997ea6239d6115978f86f26fb918b4.camel@mellanox.com>
Date:   Tue, 25 Feb 2020 22:50:29 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Roi Dayan <roid@...lanox.com>,
        "saeedm@....mellanox.co.il" <saeedm@....mellanox.co.il>,
        Paul Blakey <paulb@...lanox.com>,
        "xiangxia.m.yue@...il.com" <xiangxia.m.yue@...il.com>,
        "gerlitz.or@...il.com" <gerlitz.or@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [net-next] net/mlx5e: Remove the unnecessary parameter

On Wed, 2020-02-26 at 00:03 +0800, xiangxia.m.yue@...il.com wrote:
> From: Tonghao Zhang <xiangxia.m.yue@...il.com>
> 
> The parameter desired_size is always 0, and there is only one
> function calling the mlx5_esw_chains_get_avail_sz_from_pool.
> Deleting the parameter desired_size.

Paul, what is the reasoning behind desired size, i confirm that it  is
not actually used right now, do we have a pending patch that needs it
? 
if this is not going to happen in the near future i vote to apply this
patch and bring it back when needed.


Thanks,
Saeed.

> 
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@...il.com>
> ---
>  .../net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c | 11
> +++--------
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> index c5a446e..ce5b7e1 100644
> ---
> a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> +++
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_chains.c
> @@ -134,19 +134,14 @@ static unsigned int
> mlx5_esw_chains_get_level_range(struct mlx5_eswitch *esw)
>  	return FDB_TC_LEVELS_PER_PRIO;
>  }
>  
> -#define POOL_NEXT_SIZE 0
>  static int
> -mlx5_esw_chains_get_avail_sz_from_pool(struct mlx5_eswitch *esw,
> -				       int desired_size)
> +mlx5_esw_chains_get_avail_sz_from_pool(struct mlx5_eswitch *esw)
>  {
>  	int i, found_i = -1;
>  
>  	for (i = ARRAY_SIZE(ESW_POOLS) - 1; i >= 0; i--) {
> -		if (fdb_pool_left(esw)[i] && ESW_POOLS[i] >
> desired_size) {
> +		if (fdb_pool_left(esw)[i])
>  			found_i = i;
> -			if (desired_size != POOL_NEXT_SIZE)
> -				break;
> -		}
>  	}
>  
>  	if (found_i != -1) {
> @@ -198,7 +193,7 @@ static unsigned int
> mlx5_esw_chains_get_level_range(struct mlx5_eswitch *esw)
>  		ft_attr.flags |= (MLX5_FLOW_TABLE_TUNNEL_EN_REFORMAT |
>  				  MLX5_FLOW_TABLE_TUNNEL_EN_DECAP);
>  
> -	sz = mlx5_esw_chains_get_avail_sz_from_pool(esw,
> POOL_NEXT_SIZE);
> +	sz = mlx5_esw_chains_get_avail_sz_from_pool(esw);
>  	if (!sz)
>  		return ERR_PTR(-ENOSPC);
>  	ft_attr.max_fte = sz;