netdev - Re: [patch net-next 01/10] flow_offload: pass action cookie through offload structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200224201647.2d3b6239@cakuba.hsd1.ca.comcast.net>
Date:   Mon, 24 Feb 2020 20:16:47 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next 01/10] flow_offload: pass action cookie through
 offload structures

On Mon, 24 Feb 2020 22:07:49 +0100, Jiri Pirko wrote:
> +struct flow_action_cookie {
> +	unsigned int cookie_len;
> +	unsigned long cookie[0];
> +};

nit: there's an ongoing effort to convert [0] to []

also since cookie_len is in bytes it feels like a leaky abstraction
to have the field as unsigned long (rather than u8)