netdev - Re: [PATCH bpf-next 7/7] selftests: bpf: enable UDP sockmap reuseport tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Feb 2020 14:12:56 +0100
From:   Jakub Sitnicki <jakub@...udflare.com>
To:     Lorenz Bauer <lmb@...udflare.com>
Cc:     ast@...nel.org, daniel@...earbox.net, john.fastabend@...il.com,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        kernel-team@...udflare.com
Subject: Re: [PATCH bpf-next 7/7] selftests: bpf: enable UDP sockmap reuseport tests

On Tue, Feb 25, 2020 at 02:56 PM CET, Lorenz Bauer wrote:
> Remove the guard that disables UDP tests now that sockmap has support for them.
>
> Signed-off-by: Lorenz Bauer <lmb@...udflare.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index 68d452bb9fd9..4c09766344a4 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -816,13 +816,6 @@ static void test_config(int sotype, sa_family_t family, bool inany)
>  		if (!test__start_subtest(s))
>  			continue;
>
> -		if (sotype == SOCK_DGRAM &&
> -		    inner_map_type != BPF_MAP_TYPE_REUSEPORT_SOCKARRAY) {
> -			/* SOCKMAP/SOCKHASH don't support UDP yet */
> -			test__skip();
> -			continue;
> -		}
> -
>  		setup_per_test(sotype, family, inany, t->no_inner_map);
>  		t->fn(sotype, family);
>  		cleanup_per_test(t->no_inner_map);

This one will need a respin due to 779e422d1198 ("selftests/bpf: Run
reuseport tests only with supported socket types") that landed recently
in bpf-next.