netdev - Re: [PATCH bpf-next v2 4/4] bpf: inet_diag: Dump bpf_sk_storages in inet_diag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <938a0461-fd8d-b4b9-4fef-95d46409c0d6@iogearbox.net>
Date:   Wed, 26 Feb 2020 18:21:33 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Martin KaFai Lau <kafai@...com>, bpf@...r.kernel.org
Cc:     Alexei Starovoitov <ast@...nel.org>,
        David Miller <davem@...emloft.net>, kernel-team@...com,
        netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH bpf-next v2 4/4] bpf: inet_diag: Dump bpf_sk_storages in
 inet_diag_dump()

On 2/26/20 12:04 AM, Martin KaFai Lau wrote:
> This patch will dump out the bpf_sk_storages of a sk
> if the request has the INET_DIAG_REQ_SK_BPF_STORAGES nlattr.
> 
> An array of SK_DIAG_BPF_STORAGE_REQ_MAP_FD can be specified in
> INET_DIAG_REQ_SK_BPF_STORAGES to select which bpf_sk_storage to dump.
> If no map_fd is specified, all bpf_sk_storages of a sk will be dumped.
> 
> bpf_sk_storages can be added to the system at runtime.  It is difficult
> to find a proper static value for cb->min_dump_alloc.
> 
> This patch learns the nlattr size required to dump the bpf_sk_storages
> of a sk.  If it happens to be the very first nlmsg of a dump and it
> cannot fit the needed bpf_sk_storages,  it will try to expand the
> skb by "pskb_expand_head()".
> 
> Instead of expanding it in inet_sk_diag_fill(), it is expanded at a
> sleepable context in __inet_diag_dump() so __GFP_DIRECT_RECLAIM can
> be used.  In __inet_diag_dump(), it will retry as long as the
> skb is empty and the cb->min_dump_alloc becomes larger than before.
> cb->min_dump_alloc is bounded by KMALLOC_MAX_SIZE.  The min_dump_alloc
> is also changed from 'u16' to 'u32' to accommodate a sk that may have
> a few large bpf_sk_storages.
> 
> The updated cb->min_dump_alloc will also be used to allocate the skb in
> the next dump.  This logic already exists in netlink_dump().
> 
> Here is the sample output of a locally modified 'ss' and it could be made
> more readable by using BTF later:
> [root@...h-fb-vm1 ~]# ss --bpf-map-id 14 --bpf-map-id 13 -t6an 'dst [::1]:8989'
> State Recv-Q Send-Q Local Address:Port  Peer Address:PortProcess
> ESTAB 0      0              [::1]:51072        [::1]:8989
> 	 bpf_map_id:14 value:[ 3feb ]
> 	 bpf_map_id:13 value:[ 3f ]
> ESTAB 0      0              [::1]:51070        [::1]:8989
> 	 bpf_map_id:14 value:[ 3feb ]
> 	 bpf_map_id:13 value:[ 3f ]
> 
> [root@...h-fb-vm1 ~]# ~/devshare/github/iproute2/misc/ss --bpf-maps -t6an 'dst [::1]:8989'
> State         Recv-Q         Send-Q                   Local Address:Port                    Peer Address:Port         Process
> ESTAB         0              0                                [::1]:51072                          [::1]:8989
> 	 bpf_map_id:14 value:[ 3feb ]
> 	 bpf_map_id:13 value:[ 3f ]
> 	 bpf_map_id:12 value:[ 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000... total:65407 ]
> ESTAB         0              0                                [::1]:51070                          [::1]:8989
> 	 bpf_map_id:14 value:[ 3feb ]
> 	 bpf_map_id:13 value:[ 3f ]
> 	 bpf_map_id:12 value:[ 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000 0000... total:65407 ]
> 
> Acked-by: Song Liu <songliubraving@...com>
> Signed-off-by: Martin KaFai Lau <kafai@...com>

Hmm, the whole approach is not too pleasant to be honest. I can see why you need
it since the regular sk_storage lookup only takes sock fd as a key and you don't
have it otherwise available from outside, but then dumping up to KMALLOC_MAX_SIZE
via netlink skb is not a great experience either. :( Also, are we planning to add
the BTF dump there in addition to bpftool? Thus resulting in two different lookup
APIs and several tools needed for introspection instead of one? :/ Also, how do we
dump task local storage maps in future? Does it need a third lookup interface?

In your commit logs I haven't read on other approaches and why they won't work;
I was wondering, given sockets are backed by inodes, couldn't we have a variant
of iget_locked() (minus the alloc_inode() part from there) where you pass in ino
number to eventually get to the socket and then dump the map value associated with
it the regular way from bpf() syscall?

Thanks,
Daniel