lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Feb 2020 18:25:06 +0000 From: Russell King - ARM Linux admin <linux@...linux.org.uk> To: Vladimir Oltean <olteanv@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Linux Doc Mailing List <linux-doc@...r.kernel.org>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Ioana Ciornei <ioana.ciornei@....com>, linux-stm32@...md-mailman.stormreply.com, Florian Fainelli <f.fainelli@...il.com>, Ioana Radulescu <ruxandra.radulescu@....com>, Jonathan Corbet <corbet@....net>, Michal Simek <michal.simek@...inx.com>, Jose Abreu <joabreu@...opsys.com>, Jakub Kicinski <kuba@...nel.org>, Mark Lee <Mark-MC.Lee@...iatek.com>, Sean Wang <sean.wang@...iatek.com>, Alexandre Torgue <alexandre.torgue@...com>, Hauke Mehrtens <hauke@...ke-m.de>, Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@...ts.infradead.org>, John Crispin <john@...ozen.org>, Matthias Brugger <matthias.bgg@...il.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@...ts.infradead.org>, netdev <netdev@...r.kernel.org>, Vivien Didelot <vivien.didelot@...il.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, Felix Fietkau <nbd@....name>, "David S. Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com> Subject: Re: [PATCH net-next v2 1/8] net: phylink: propagate resolved link config via mac_link_up() On Wed, Feb 26, 2020 at 08:22:39PM +0200, Vladimir Oltean wrote: > On Wed, 26 Feb 2020 at 20:21, Vladimir Oltean <olteanv@...il.com> wrote: > > > > On Wed, 26 Feb 2020 at 15:36, Russell King - ARM Linux admin > > <linux@...linux.org.uk> wrote: > > > > > > > > > dpaa2 is complicated by the firmware, and that we can't switch the > > > interface mode between (SGMII,1000base-X) and 10G. > > > > > > If the firmware is in "DPMAC_LINK_TYPE_PHY" mode, it expects to be told > > > the current link parameters via the dpmac_set_link_state() call - it > > > isn't clear whether that needs to be called for other modes with the > > > up/down state (firmware API documentation is poor.) > > > > > > > With PCS control in Linux, I am pretty sure that you don't want > > anything other than DPMAC_LINK_TYPE_PHY anyway. > > Basically in DPMAC_LINK_TYPE_FIXED, the MC firmware is in control of > > the PCS and polls its link state to emit link notifications to objects > > connected to the DPMAC. So Linux control of PCS would class with > > s/class/clash/ > > > firmware control of the PCS, leading to undesirable side-effects to > > say the least. Yes, which is why we only register the PCS with phylink if we're in DPMAC_LINK_TYPE_PHY mode. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Powered by blists - more mailing lists