netdev - Re: [PATCH net-next v3 1/2] net: switchdev: do not propagate bridge updates across bridges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e03d821b-1cf1-646d-2582-58ebbf00cf50@gmail.com>
Date:   Wed, 26 Feb 2020 14:30:05 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Russell King <rmk+kernel@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>,
        Ivan Vecera <ivecera@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v3 1/2] net: switchdev: do not propagate bridge
 updates across bridges

On 2/26/20 9:14 AM, Russell King wrote:
> When configuring a tree of independent bridges, propagating changes
> from the upper bridge across a bridge master to the lower bridge
> ports brings surprises.
> 
> For example, a lower bridge may have vlan filtering enabled.  It
> may have a vlan interface attached to the bridge master, which may
> then be incorporated into another bridge.  As soon as the lower
> bridge vlan interface is attached to the upper bridge, the lower
> bridge has vlan filtering disabled.
> 
> This occurs because switchdev recursively applies its changes to
> all lower devices no matter what.
> 
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> Tested-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian