netdev - Re: [Intel-wired-lan] [PATCH next] igc: make non-global functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1453037a-4370-8c08-f8c9-dfaa629e96b0@intel.com>
Date:   Wed, 26 Feb 2020 15:32:37 -0800
From:   "Neftin, Sasha" <sasha.neftin@...el.com>
To:     Chen Zhou <chenzhou10@...wei.com>, jeffrey.t.kirsher@...el.com,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH next] igc: make non-global functions
 static

On 1/8/2020 05:39, Chen Zhou wrote:
> Fix sparse warning:
> drivers/net/ethernet/intel/igc/igc_ptp.c:512:6:
> 	warning: symbol 'igc_ptp_tx_work' was not declared. Should it be static?
> drivers/net/ethernet/intel/igc/igc_ptp.c:644:6:
> 	warning: symbol 'igc_ptp_suspend' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Chen Zhou <chenzhou10@...wei.com>
> ---
>   drivers/net/ethernet/intel/igc/igc_ptp.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c
> index 6935065..389a969 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ptp.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ptp.c
> @@ -509,7 +509,7 @@ static void igc_ptp_tx_hwtstamp(struct igc_adapter *adapter)
>    * This work function polls the TSYNCTXCTL valid bit to determine when a
>    * timestamp has been taken for the current stored skb.
>    */
> -void igc_ptp_tx_work(struct work_struct *work)
> +static void igc_ptp_tx_work(struct work_struct *work)
>   {
>   	struct igc_adapter *adapter = container_of(work, struct igc_adapter,
>   						   ptp_tx_work);
> @@ -641,7 +641,7 @@ void igc_ptp_init(struct igc_adapter *adapter)
>    * This function stops the overflow check work and PTP Tx timestamp work, and
>    * will prepare the device for OS suspend.
>    */
> -void igc_ptp_suspend(struct igc_adapter *adapter)
> +static void igc_ptp_suspend(struct igc_adapter *adapter)
>   {
>   	if (!(adapter->ptp_flags & IGC_PTP_ENABLED))
>   		return;
> 
This patch should be partially reverted for "igc_ptp_suspend".
"igc_ptp_suspend" declared in igc.h file and used in "__igc_shutdown" 
method.