netdev - Re: [PATCH net-next v2 0/2] net/smc: improve peer ID in CLC decline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <cd02abb7-7175-8603-0c1c-f5916feb464e@linux.ibm.com>
Date:   Wed, 26 Feb 2020 09:33:28 +0100
From:   Karsten Graul <kgraul@...ux.ibm.com>
To:     Hans Wippel <ndev@...pl.net>, ubraun@...ux.ibm.com,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/2] net/smc: improve peer ID in CLC decline


Acked-by: Karsten Graul <kgraul@...ux.ibm.com>


On 25/02/2020 22:41, Hans Wippel wrote:
> The following two patches improve the peer ID in CLC decline messages if
> RoCE devices are present in the host but no suitable device is found for
> a connection. The first patch reworks the peer ID initialization. The
> second patch contains the actual changes of the CLC decline messages.
> 
> Changes v1 -> v2:
> * make smc_ib_is_valid_local_systemid() static in first patch
> * changed if in smc_clc_send_decline() to remove curly braces
> 
> Changes RFC -> v1:
> * split the patch into two parts
> * removed zero assignment to global variable (thanks Leon)
> 
> Thanks to Leon Romanovsky and Karsten Graul for the feedback!
> 
> Hans Wippel (2):
>   net/smc: rework peer ID handling
>   net/smc: improve peer ID in CLC decline for SMC-R
> 
>  net/smc/smc_clc.c |  3 ++-
>  net/smc/smc_ib.c  | 19 ++++++++++++-------
>  net/smc/smc_ib.h  |  1 +
>  3 files changed, 15 insertions(+), 8 deletions(-)
> 

-- 
Karsten

(I'm a dude)