netdev - Re: [patch net] sched: act: count in the size of action flags bitfield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200226.171159.1683991665921037285.davem@davemloft.net>
Date:   Wed, 26 Feb 2020 17:11:59 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, kuba@...nel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, vladbu@...lanox.com, mlxsw@...lanox.com
Subject: Re: [patch net] sched: act: count in the size of action flags
 bitfield

From: Jiri Pirko <jiri@...nulli.us>
Date: Tue, 25 Feb 2020 13:54:12 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> The put of the flags was added by the commit referenced in fixes tag,
> however the size of the message was not extended accordingly.
> 
> Fix this by adding size of the flags bitfield to the message size.
> 
> Fixes: e38226786022 ("net: sched: update action implementations to support flags")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for v5.5 -stable, thanks Jiri.

This is a common mistake which is made when adding new attributes, so it would
be nice if there were a programmatic way to make sure these adjustments never
get forgotten.