netdev - Re: [patch net v2] mlx5: register lag notifier for init network namespace only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200227.111646.1790531386593657307.davem@davemloft.net>
Date:   Thu, 27 Feb 2020 11:16:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, kuba@...nel.org, ayal@...lanox.com,
        saeedm@...lanox.com, ranro@...lanox.com, moshe@...lanox.com
Subject: Re: [patch net v2] mlx5: register lag notifier for init network
 namespace only

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 27 Feb 2020 08:22:10 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> The current code causes problems when the unregistering netdevice could
> be different then the registering one.
> 
> Since the check in mlx5_lag_netdev_event() does not allow any other
> network namespace anyway, fix this by registerting the lag notifier
> per init network namespace only.
> 
> Fixes: d48834f9d4b4 ("mlx5: Use dev_net netdevice notifier registrations")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> Tested-by: Aya Levin <ayal@...lanox.com>
> Acked-by: Saeed Mahameed <saeedm@...lanox.com>
> ---
> v1->v2:
> - removed unused variable

Applied, thanks for the quick follow-up Jiri.