netdev - Re: [patch net] mlxsw: pci: Wait longer before accessing the device after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200227.121030.348000556990403150.davem@davemloft.net>
Date:   Thu, 27 Feb 2020 12:10:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, kuba@...nel.org, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net] mlxsw: pci: Wait longer before accessing the
 device after reset

From: Jiri Pirko <jiri@...nulli.us>
Date: Thu, 27 Feb 2020 21:07:53 +0100

> From: Amit Cohen <amitc@...lanox.com>
> 
> During initialization the driver issues a reset to the device and waits
> for 100ms before checking if the firmware is ready. The waiting is
> necessary because before that the device is irresponsive and the first
> read can result in a completion timeout.
> 
> While 100ms is sufficient for Spectrum-1 and Spectrum-2, it is
> insufficient for Spectrum-3.
> 
> Fix this by increasing the timeout to 200ms.
> 
> Fixes: da382875c616 ("mlxsw: spectrum: Extend to support Spectrum-3 ASIC")
> Signed-off-by: Amit Cohen <amitc@...lanox.com>
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Applied and queued up for -stable, thanks Jiri.