netdev - Re: [PATCH net-next 6/7] mptcp: avoid work queue scheduling if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.OSX.2.22.394.2002261611420.50710@tvtrimel-mobl2.amr.corp.intel.com>
Date:   Wed, 26 Feb 2020 16:11:58 -0800 (PST)
From:   Mat Martineau <mathew.j.martineau@...ux.intel.com>
To:     Florian Westphal <fw@...len.de>
cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next 6/7] mptcp: avoid work queue scheduling if
 possible

On Wed, 26 Feb 2020, Florian Westphal wrote:

> We can't lock_sock() the mptcp socket from the subflow data_ready callback,
> it would result in ABBA deadlock with the subflow socket lock.
>
> We can however grab the spinlock: if that succeeds and the mptcp socket
> is not owned at the moment, we can process the new skbs right away
> without deferring this to the work queue.
>
> This avoids the schedule_work and hence the small delay until the
> work item is processed.
>
> Signed-off-by: Florian Westphal <fw@...len.de>

Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>

--
Mat Martineau
Intel