netdev - Re: [PATCH v2 net-next] tcp-zerocopy: Update returned getsockopt() optlen.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200226.202453.378034778398671449.davem@davemloft.net>
Date:   Wed, 26 Feb 2020 20:24:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arjunroy.kdev@...il.com
Cc:     netdev@...r.kernel.org, arjunroy@...gle.com, soheil@...gle.com,
        edumazet@...gle.com, willemb@...gle.com
Subject: Re: [PATCH v2 net-next] tcp-zerocopy: Update returned getsockopt()
 optlen.

From: Arjun Roy <arjunroy.kdev@...il.com>
Date: Tue, 25 Feb 2020 12:38:54 -0800

> From: Arjun Roy <arjunroy@...gle.com>
> 
> TCP receive zerocopy currently does not update the returned optlen for
> getsockopt() if the user passed in a larger than expected value.
> Thus, userspace cannot properly determine if all the fields are set in
> the passed-in struct. This patch sets the optlen for this case before
> returning, in keeping with the expected operation of getsockopt().
> 
> Fixes: c8856c051454 ("tcp-zerocopy: Return inq along with tcp receive zerocopy.")
> Signed-off-by: Arjun Roy <arjunroy@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

Applied, thank you.