lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Feb 2020 07:19:30 +0100 From: Jiri Pirko <jiri@...nulli.us> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, kuba@...nel.org, ayal@...lanox.com, saeedm@...lanox.com, ranro@...lanox.com, moshe@...lanox.com Subject: Re: [patch net] mlx5: register lag notifier for init network namespace only Thu, Feb 27, 2020 at 01:52:39AM CET, davem@...emloft.net wrote: >From: David Miller <davem@...emloft.net> >Date: Wed, 26 Feb 2020 16:50:48 -0800 (PST) > >> From: Jiri Pirko <jiri@...nulli.us> >> Date: Tue, 25 Feb 2020 10:25:46 +0100 >> >>> From: Jiri Pirko <jiri@...lanox.com> >>> >>> The current code causes problems when the unregistering netdevice could >>> be different then the registering one. >>> >>> Since the check in mlx5_lag_netdev_event() does not allow any other >>> network namespace anyway, fix this by registerting the lag notifier >>> per init network namespace only. >>> >>> Fixes: d48834f9d4b4 ("mlx5: Use dev_net netdevice notifier registrations") >>> Signed-off-by: Jiri Pirko <jiri@...lanox.com> >>> Tested-by: Aya Levin <ayal@...lanox.com> >> >> Applied, thank you. > >Actually, you need to respin this and fix the following warning: > >drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function ‘mlx5e_uplink_rep_disable’: >drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1864:21: warning: unused variable ‘netdev’ [-Wunused-variable] > struct net_device *netdev = priv->netdev; > ^~~~~~ > >You can retain Saeed's ACK when you do this. Okay. Will do. > >Thank you.
Powered by blists - more mailing lists