netdev - Re: [PATCH net-next v2 2/2] net: datagram: drop 'destructor' argument from several helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+FuTSfD157LSzfswU5ssVwc-kbTSVooKFmCo1pjJC+cO+crzA@mail.gmail.com>
Date:   Fri, 28 Feb 2020 11:10:56 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     Paolo Abeni <pabeni@...hat.com>,
        Network Development <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v2 2/2] net: datagram: drop 'destructor' argument
 from several helpers

On Fri, Feb 28, 2020 at 9:50 AM Kirill Tkhai <ktkhai@...tuozzo.com> wrote:
>
> On 28.02.2020 16:45, Paolo Abeni wrote:
> > The only users for such argument are the UDP protocol and the UNIX
> > socket family. We can safely reclaim the accounted memory directly
> > from the UDP code and, after the previous patch, we can do scm
> > stats accounting outside the datagram helpers.
> >
> > Overall this cleans up a bit some datagram-related helpers, and
> > avoids an indirect call per packet in the UDP receive path.
> >
> > v1 -> v2:
> >  - call scm_stat_del() only when not peeking - Kirill
> >  - fix build issue with CONFIG_INET_ESPINTCP
> >
> > Signed-off-by: Paolo Abeni <pabeni@...hat.com>
>
> Reviewed-by: Kirill Tkhai <ktkhai@...tuozzo.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>

Nice cleanup, thanks!