netdev - Re: [PATCH net] net/ipv6: use configured matric when add peer route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Feb 2020 08:32:34 -0800
From:   Roopa Prabhu <roopa@...ulusnetworks.com>
To:     Hangbin Liu <liuhangbin@...il.com>
Cc:     netdev <netdev@...r.kernel.org>, David Ahern <dsahern@...il.com>,
        Jianlin Shi <jishi@...hat.com>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH net] net/ipv6: use configured matric when add peer route

On Fri, Feb 28, 2020 at 1:19 AM Hangbin Liu <liuhangbin@...il.com> wrote:
>
> When we add peer address with metric configured, IPv4 could set the dest
> metric correctly, but IPv6 do not. e.g.
>
> ]# ip addr add 192.0.2.1 peer 192.0.2.2/32 dev eth1 metric 20
> ]# ip route show dev eth1
> 192.0.2.2 proto kernel scope link src 192.0.2.1 metric 20
> ]# ip addr add 2001:db8::1 peer 2001:db8::2/128 dev eth1 metric 20
> ]# ip -6 route show dev eth1
> 2001:db8::1 proto kernel metric 20 pref medium
> 2001:db8::2 proto kernel metric 256 pref medium
>
> Fix this by using configured matric instead of default one.
>
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Fixes: 8308f3ff1753 ("net/ipv6: Add support for specifying metric of connected routes")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---

noticed the typo in the patch title : s/matric/metric/


>  net/ipv6/addrconf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index cb493e15959c..164c71c54b5c 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -5983,9 +5983,9 @@ static void __ipv6_ifa_notify(int event, struct inet6_ifaddr *ifp)
>                 if (ifp->idev->cnf.forwarding)
>                         addrconf_join_anycast(ifp);
>                 if (!ipv6_addr_any(&ifp->peer_addr))
> -                       addrconf_prefix_route(&ifp->peer_addr, 128, 0,
> -                                             ifp->idev->dev, 0, 0,
> -                                             GFP_ATOMIC);
> +                       addrconf_prefix_route(&ifp->peer_addr, 128,
> +                                             ifp->rt_priority, ifp->idev->dev,
> +                                             0, 0, GFP_ATOMIC);
>                 break;
>         case RTM_DELADDR:
>                 if (ifp->idev->cnf.forwarding)
> --
> 2.19.2
>